[tip:sched/core] sched, autogroup: Fix reference leak

From: tip-bot for Mike Galbraith
Date: Tue Jan 04 2011 - 09:19:47 EST


Commit-ID: 101e5f77bf35679809586e250b6c62193d2ed179
Gitweb: http://git.kernel.org/tip/101e5f77bf35679809586e250b6c62193d2ed179
Author: Mike Galbraith <efault@xxxxxx>
AuthorDate: Fri, 31 Dec 2010 09:32:30 +0100
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Tue, 4 Jan 2011 15:10:36 +0100

sched, autogroup: Fix reference leak

The cgroup exit mess also uncovered a struct autogroup reference leak.
copy_process() was simply freeing vs putting the signal_struct,
stranding a reference.

Signed-off-by: Mike Galbraith <efault@xxxxxx>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
LKML-Reference: <1293784350.6839.2.camel@xxxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
kernel/fork.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index b6f2475..0672444 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1317,7 +1317,7 @@ bad_fork_cleanup_mm:
}
bad_fork_cleanup_signal:
if (!(clone_flags & CLONE_THREAD))
- free_signal_struct(p->signal);
+ put_signal_struct(p->signal);
bad_fork_cleanup_sighand:
__cleanup_sighand(p->sighand);
bad_fork_cleanup_fs:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/