Re: [PATCH resend] Update atime from future.

From: Valdis . Kletnieks
Date: Tue Jan 04 2011 - 15:32:14 EST


On Tue, 04 Jan 2011 12:13:37 MST, Andreas Dilger said:
> On 2011-01-04, at 11:21, Valdis.Kletnieks@xxxxxx wrote:
> > On Tue, 04 Jan 2011 16:56:58 +0800, yangsheng said:
> >> If atime has been wrong set to future, then it cannot
> >> be updated back to current time.
> >>
> >> +#define RELATIME_MARGIN (24 * 60 * 60)
> >
> > Nice patch overall. Should this be a #define, or a CONFIG_ variable,
> > or a tweakable /proc/sys/fs variable? Or am I senile and we thrashed
> > all this out once before when the relatime code landed?
>
> I recall the consensus was that a /proc tunable was "too much" for the
> initial patch.

OK, in that case yangsheng's patch is probably good to go.

Attachment: pgp00000.pgp
Description: PGP signature