Re: [PATCH 1/1] mct_u232: added _ioctl, _msr_to_icount and_get_icount functions

From: Greg KH
Date: Wed Jan 05 2011 - 17:43:54 EST


On Mon, Dec 27, 2010 at 12:55:38PM -0800, Tsozik wrote:
> Pete,
>
> You're absolutely right. My apology again, I re-checked values of MSR masks used to update icount counters and they all belong to upper MSR nibble, so they indeed track changes (not states). I took out counter increments from mct_u232_msr_to_state function and encapsulated them in the newly defined mct_u232_msr_to_icount function, effectively leaving the previous implementation of mct_u232_msr_to_state function intact. mct_u232_msr_to_icount uses delta nibble to track state changes. RM-60 testing showed the same levels as measured by PDM-2 in close proximity to RM-60. Please let me know if anything else needs to be corrected to roll this out,

Can you not attach the patch as a base64 attachment? I can't apply it
as-is, because of that, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/