Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485

From: Alan Cox
Date: Thu Jan 06 2011 - 08:36:16 EST

> With this patch, TIOCSRS485 gets the same value across all
> architectures, making maintenance and portability of user-level code
> easier.

I don't see why this is worth doing - no application code should ever
hardcode the value.

> + case TIOCSRS485DEPR:
> + {
> + printk(KERN_DEBUG "The use of this ioctl is deprecated. Use TIOCSRS485 instead\n");
> + /* Fall through */
> + }

and letting everyone spew printks is not a good thing.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at