Re: [PATCH V2] ST SPEAr: PCIE gadget suppport

From: Andrew Morton
Date: Thu Jan 06 2011 - 15:19:27 EST

On Thu, 6 Jan 2011 17:29:10 +0530
Viresh Kumar <viresh.kumar@xxxxxx> wrote:

> From: Pratyush Anand <pratyush.anand@xxxxxx>
> This is a configurable gadget. can be configured by sysfs interface. Any
> IP available at PCIE bus can be programmed to be used by host
> controller.It supoorts both INTX and MSI.
> By default, gadget is configured for INTX and SYSRAM1 is mapped to BAR0
> with size 0x1000
> ...
> --- /dev/null
> +++ b/Documentation/misc-devices/spear-pcie-gadget.txt

Please recheck this documentation file - it contains a number of simple

> ...
> + if (strict_strtoul(buf, 0, &config->requested_msi))
> + return -EINVAL;

It doesn't matter much, but the code really should propagate the
strict_strtoul() return error code back to the caller, rather than
overwriting it with -EINVAL.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at