Re: + hugetlb-handle-nodemask_alloc-failure-correctly.patch addedto -mm tree

From: Michal Hocko
Date: Fri Jan 07 2011 - 03:25:49 EST

On Thu 06-01-11 16:42:06, David Rientjes wrote:
> On Thu, 6 Jan 2011, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> This patch is wrong, both functions may handle a NULL nodes_allowed, which
> is why the __GFP_NORETRY is explicitly part of the gfp mask.
> In both functions, init_nodemask_of_mempolicy() will immediately return
> false if the mask is NULL. If so, it is set to node_states[N_HIGH_MEMORY]
> in the caller and we're careful to avoid calling the NODMASK_FREE() in
> that case. They are carefully coded in this way so they operate over all
> nodes with memory rather than failing with -ENOMEM.

OK, I see. Thanks for the review.

Michal Hocko
L3 team
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at