Re: [PATCH V8 02/13] ntp: add ADJ_SETOFFSET mode bit

From: Kuwahara,T.
Date: Mon Jan 10 2011 - 15:47:58 EST


On Mon, Jan 10, 2011 at 4:17 PM, Richard Cochran
<richardcochran@xxxxxxxxx> wrote:
> the PTP Hardware Clocks for which this whole patch
> set was created in the first place will keep their time as TAI.

Are you sure of that? I don't have the standard handy (it's non-free,
right?) but it seems that the Annex B states differently. But that's
not the point anyway. My concern is that your patch not only adds the
useless (and broken) feature to the existing syscall but also makes a
permanent change to the public interface for your own use. That's
what I'm against. So if you stop touching the struct timex, I won't
complain anymore.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/