Re: [PATCH -v3 4/4] x86: usb handoff in early_quirk

From: Yinghai Lu
Date: Mon Jan 10 2011 - 20:43:49 EST


On 01/10/2011 05:08 PM, Greg KH wrote:
> On Mon, Jan 10, 2011 at 04:55:33PM -0800, Yinghai Lu wrote:
>>
>> some systems keep getting
>> APIC calibration not consistent with PM-Timer: 139ms instead of 100ms
>> APIC delta adjusted to PM-Timer: 831249 (1163736)
>>
>> USB legacy SMI handler is not disabled at that time.
>>
>> Try to disable USB legacy support early with this patch.
>> So later APIC Timer calibration don't get messed up by USB legacy support SMI handler.
>> After this patch, that warning never show up for 100 reboot tests.
>
> So all of this work was for one warning that really doesn't mean much,
> if anything? That seems very pointless, wouldn't you agree?
>
> Wouldn't it be nicer if the BIOS fixed the SMI code to not have such
> problems?

find detail info that calibration code from Thomas
http://lkml.indiana.edu/hypermail/linux/kernel/0703.2/0420.html

Thomas said:
The wrong calibration values are probably caused by SMM code trying to
emulate a PS/2 keyboard from a (maybe connected or not) USB keyboard.
This prohibits the accurate delivery of PIT interrupts, which are used
to calibrate the local APIC timer. Unfortunately we have no way to
disable this BIOS misfeature in the early boot process.
---

We could disable it early with x86 early_quirks.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/