Re: [tip:x86/tsc] x86: Improve TSC calibration using a delayedworkqueue

From: Thomas Gleixner
Date: Tue Jan 11 2011 - 05:26:50 EST


On Tue, 11 Jan 2011, Kirill A. Shutemov wrote:
> On Tue, Jan 11, 2011 at 09:37:15AM +0100, Thomas Gleixner wrote:
> > Does the patch below fix it ? We can end up with tsc_khz=0 there :(
>
> Yes, it does.
>
> Bisected-and-tested-by: Kirill A. Shutemov <kas@xxxxxxxxxx>

Looking deeper, we should avoid to schedule the delayed init
completely. Does that work as well ?

Thanks,

tglx
---

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 03d2ea8..823f79a 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -965,7 +965,7 @@ out:

static int __init init_tsc_clocksource(void)
{
- if (!cpu_has_tsc || tsc_disabled > 0)
+ if (!cpu_has_tsc || tsc_disabled > 0 || !tsc_khz)
return 0;

if (tsc_clocksource_reliable)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/