Re: [PATCH] rt2x00: Don't leak mem in error path of rt2x00lib_request_firmware()

From: Pekka Enberg
Date: Tue Jan 11 2011 - 12:33:20 EST


On Tue, Jan 11, 2011 at 7:30 PM, Ivo Van Doorn <ivdoorn@xxxxxxxxx> wrote:
> Hi,
>
>> We need to release_firmware() in order not to leak memory.
>>
>> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
>
> I can assume that release_firmware() checks if 'fw' is null?

Yes, it does.

> If so:
>
> Acked-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>

Acked-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/