Re: linux-next: build failure after merge of the pci tree

[Stephen Rothwell]

Hi Narendra,

On Tue, 11 Jan 2011 20:48:21 +0530 <Narendra_K@xxxxxxxx> wrote:
>
> On Mon, Jan 10, 2011 at 07:24:11AM +0530, Stephen Rothwell wrote:
> > 
> > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > drivers/built-in.o: In function `T.647':
> > pci-label.c:(.text+0x28514): undefined reference to `utf16s_to_utf8s'
> > 
> > Caused by commit a6247cd4be20cb5439db5cb7b0b6cc67fdc8e2a2 ("PCI: export
> > ACPI _DSM provided firmware instance number and string to sysfs").
> > 
> > I have used the pci tree from next-20110107 for today.
> 
> I did a git pull of linux-next-20110110 (topmost commit is 
> 4c897f27ad2668534f719202a3b88abe8ec31011) and applied the patch. With 
> CONFIG_DMI and CONFIG_ACPI both set, I did not encounter this build failure. 
> The definition for `utf16s_to_utf8s' is available in 'include/linux/nls.h' 
> which is included in 'drivers/pci/pci-label.c' and the build succeeded. Sorry 
> if I am missing something here.

I did an x86_64 allmodconfig build (see above) which has CONFIG_NLS=m and
so utf16s_to_utf8s is not available to built in code ...

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature