Re: [patch] Re: autogroup: sched_setscheduler() fails

[Yong Zhang]

On Tue, Jan 11, 2011 at 12:42 AM, Mike Galbraith <efault@xxxxxx> wrote:
> Index: linux-2.6/kernel/sched_autogroup.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched_autogroup.c
> +++ linux-2.6/kernel/sched_autogroup.c
> @@ -73,6 +73,15 @@ static inline struct autogroup *autogrou
> Â Â Â Âag->id = atomic_inc_return(&autogroup_seq_nr);
> Â Â Â Âag->tg = tg;
> Â Â Â Âtg->autogroup = ag;
> +#ifdef CONFIG_RT_GROUP_SCHED
> + Â Â Â /*
> + Â Â Â Â* HACK: autogroup RT tasks run in the root task group.
> + Â Â Â Â* This fools __sched_setscheduler() into proceeding on
> + Â Â Â Â* so we can move the task to the appropriate runqueue
> + Â Â Â Â* upon scheduling policy change.
> + Â Â Â Â*/
> + Â Â Â tg->rt_bandwidth.rt_runtime = RUNTIME_INF;
> +#endif
>
> Â Â Â Âreturn ag;
>
> @@ -143,6 +152,15 @@ autogroup_move_group(struct task_struct
> Â Â Â Âautogroup_kref_put(prev);
> Â}
>
> +static inline void
> +autogroup_setscheduler(struct task_struct *p, int on_rq)
> +{
> + Â Â Â if (p->sched_class->task_move_group)
> + Â Â Â Â Â Â Â p->sched_class->task_move_group(p, on_rq);

This will be called even if we don't change the sched_class in
which case it is not necessary.

Thanks,
Yong

-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/