Re: [PATCH] Rename struct task variables from p to tsk

From: Christoph Lameter
Date: Wed Jan 12 2011 - 15:23:35 EST


On Wed, 12 Jan 2011, Eric B Munson wrote:

> On Wed, 12 Jan 2011, Christoph Lameter wrote:
> > Use t instead of p? Its a local variable after all.
>
> I don't find t any more informative than p. As a newcomer to most of this code
> informative variable names, even for local variables, is a huge help.

Local variables are short because they are defined close to the point of
use.

tsk is not that informative and the notion of a "task" can refer to
various. However, when I see

struct task_struct *t;

I know what it refers to.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/