Re: [PATCH] Quirk to fix suspend/resume on Lenovo Edge 11,13,14,15

From: Matthew Garrett
Date: Thu Jan 13 2011 - 12:39:30 EST


On Thu, Jan 13, 2011 at 06:10:01PM +0100, Thomas Gleixner wrote:
> On Thu, 13 Jan 2011, Matthew Garrett wrote:
>
> > On Thu, Jan 13, 2011 at 10:02:22AM -0600, Manoj Iyer wrote:
> > > Set acpi_skip_timer_override to force ignoring BIOS
> > > IRQ0 pin2 override. This fixes resume from suspend on
> > > AMD based ThinkPad Edge 11,13,14 and 15.
> >
> > This was originally there because of a quirk in some ati chipsets,
> > coupled with DSDT insanity on HP's part. The Thinkpad Edges seem to be
> > Intel machines, so it's not the same underlying issue. Do we have any
>
> The patch description above talks explictely about AMD based ThinkPad
> Edge. So it might be as well the same underlying problem.

I'm sorry, I misread that completely. The reason for the extra quirk on
the HPs was down to their DSDT setting thermal trip points incorrectly
if the override weren't ignored - it would trigger at boot time, not
after suspend/resume. In theory I think that should be handled by the
chipset-specific quirk code already, with the DMI list as a backup. It
may be that we need to look at the chipset quirk code?

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/