Re: vfs-scale, keep the errno

[Nick Piggin]

On Sat, Jan 15, 2011 at 12:17 AM, Hans-Peter Jansen <hpj@xxxxxxxxx> wrote:
> On Friday 14 January 2011, 05:01:37 Nick Piggin wrote:
>> On Fri, Jan 14, 2011 at 2:38 PM, J. R. Okajima <hooanon05@xxxxxxxxxxx>
> wrote:
>> > When open(2) without O_DIRECTORY opens an existing dir, it should
>> > return EISDIR. In do_last(), the variable 'error' is initialized
>> > EISDIR, but it is changed by d_revalidate() which returns any
>> > positive to represent 'the target dir is valid.'
>> > Should we keep and return the initialized 'error' in this case.
>>
>> Great, thank you very much. I just changed a few variable names but
>> applied it. Would you please add you Signed-off-by: on patches from
>> now on?
>>
>> Good reviewing work. Are you finding these by review or testing? I
>> think ltptests on an nfs mount should find this kind of bug... which
>> I should do.
>
> Nick, Junjiro is well known as a very smart (and|but) humble guy in the

I agree, based on the thoughtful review comments and patches :)

Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/