[patch] reiserfs: potential ERR_PTR dereference

From: Dan Carpenter
Date: Sat Jan 15 2011 - 08:46:36 EST


reiserfs_iget() returns an ERR_PTR on allocation failures. All the
other callers check for it so we should check here too.

Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 0aab04f..6949b98 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -237,7 +237,7 @@ static int finish_unfinished(struct super_block *s)
pathrelse(&path);

inode = reiserfs_iget(s, &obj_key);
- if (!inode) {
+ if (IS_ERR_OR_NULL(inode)) {
/* the unlink almost completed, it just did not manage to remove
"save" link and release objectid */
reiserfs_warning(s, "vs-2180", "iget failed for %K",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/