Re: [PATCH] param: add null statement to compiled-in module params

From: Rusty Russell
Date: Mon Jan 17 2011 - 20:09:28 EST


On Mon, 17 Jan 2011 06:42:13 pm Linus Walleij wrote:
> On 01/17/2011 12:41 AM, Rusty Russell wrote:
> > On Wed, 5 Jan 2011 10:57:04 pm Linus Walleij wrote:
> >
> >> Add an unused struct declaration statement requiring a
> >> terminating semicolon to the compile-in case to provoke an
> >> error if __MODULE_INFO() is used without the terminating
> >> semicolon. Previously MODULE_ALIAS("foo") (no semicolon)
> >> compiled fine if MODULE was not selected.
> >>
> > I really prefer the other way; make everyone use a semicolon.
> >
>
> That's what it does. Currently the kernel allows you to
> write MODULE_ALIAS("bar") sans semicolon if you
> compile in the module statically...
>
> Or am I getting things wrong?

No, I was. Sorry, I should read more carefully.

Applied, thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/