Re: [PATCH 04/16] input: tnetv107x-touchscreen: don't treat NULL clkas an error

From: Dmitry Torokhov
Date: Mon Jan 17 2011 - 23:25:59 EST


On Tue, Jan 11, 2011 at 09:56:41PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 11, 2011 at 12:43:41PM +0000, Jamie Iles wrote:
> > clk_get() returns a struct clk cookie to the driver and some platforms
> > may return NULL if they only support a single clock. clk_get() has only
> > failed if it returns a ERR_PTR() encoded pointer.
> >
> > Cc: Cyril Chemparathy <cyril@xxxxxx>
> > Cc: linux-input@xxxxxxxxxxxxxxx
> > Signed-off-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
>
> Applied both, thank you Jamie.
>

Actually, if we pass clk that is NULL along we going to get oops on many
arches, so I am going to change it to IS_ERR_OR_NULL.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/