Re: [PATCH 0/1] sysrq is half-enabled by default

From: Andy Whitcroft
Date: Tue Jan 18 2011 - 04:38:57 EST


On Sat, Jan 15, 2011 at 01:54:50PM -0800, Dmitry Torokhov wrote:
> Hi Andy,
>
> On Sat, Jan 15, 2011 at 08:23:56PM +0000, Andy Whitcroft wrote:
> > It seems that recent cleanups to sysrq handling have lead to us having
> > two copies of the sysrq enable status. At boot these are currently
> > inconsistently specified leading to sysrq actually being enabled but
> > reported as not enabled in sysfs. Following this email is a patch to
> > link both of these copies to a common configuration setting.
> >
>
> Thanks for noticing this, but I do not think we need a new configuration
> parameter. We did not have it for about 10 years and distributions know
> how to disable it upon boot if they want to.
>
> Do youthink you could cange the patch and add a default value (1) to
> inlude/linux/sysrq.h and use it in sysctl and the handler code?

Sure thing.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/