Re: [PATCH 3/3] trusted-keys: small cleanup

[Mimi Zohar]

On Tue, 2011-01-18 at 20:03 +0900, Tetsuo Handa wrote:
> Mimi Zohar wrote:
> > > >       va_end(argp);
> > > > -     ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > > > +     if (!ret)
> > > > +             ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > > >       if (!ret)
> > 
> > Change the second '(!ret)' here, the crypto_shash_file() return code
> > test, from '(!ret)' to '(ret < 0)', like the other crypto_shash_file()
> > tests.
> 
> Did you mean changing from
> 
> 	if (!ret)
> 		ret = crypto_shash_final(&sdesc->shash, paramdigest);
> 
> to
> 
> 	if (ret < 0)
> 		ret = crypto_shash_final(&sdesc->shash, paramdigest);
> 
> (i.e. invert the condition)?

Wrong '(!ret)'.  Instead of:
        va_end(argp);
        if (!ret)
                ret = crypto_shash_final(&sdesc->shash, paramdigest);
        if (!ret)

do:
        va_end(argp);
        if (!ret)
                ret = crypto_shash_final(&sdesc->shash, paramdigest);
        if (ret < 0)

> I'm confused. Would you make the patch by yourself?

It's only for consistency, not that important.

thanks,

Mimi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/