Re: [PATCH 1/3] watchdog: fix broken nowatchdog logic

[Don Zickus]

On Tue, Jan 18, 2011 at 11:37:44PM +0100, Marcin Slusarz wrote:
> Passing nowatchdog to kernel disables 2 things: creation of watchdog threads
> AND initialization of percpu watchdog_hrtimer. As hrtimers are initialized
> only at boot it's not possible to enable watchdog later - for me all watchdog
> threads started to eat 100% of CPU time, but they could just crash.
> 
> Additionally, even if these threads would start properly,
> watchdog_disable_all_cpus was guarded by no_watchdog check, so you
> couldn't disable watchdog.
> 
> To fix this, remove no_watchdog variable and use already existing
> watchdog_enabled variable.

These three patches seem reasonable.  I'll queue them up.

Thanks,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/