[PATCH v2] blktrace: Don't output messages if NOTIFY isn't set.

From: Tao Ma
Date: Tue Jan 18 2011 - 22:09:50 EST


Hi Jeff,
On 01/18/2011 11:50 PM, Jeff Moyer wrote:
> Tao Ma<tm@xxxxxx> writes:
>
>> + /*
>> + * If the user does specify some action masks, don't send any note
>> + * message to the trace so that it won't pollute what the user really
>> + * want to see.
>> + */
>> + if (bt->act_mask != (u16) -1)
>> + return;
>> +
>
> I think you want to check for the BLK_TC_NOTIFY bit.
I was thinking of this, but actually there is no way for the user to set this flag.
At least from blktrace(8), -a doesn't have any flags like NOTIFY. So if the user
set any flag, NOTIFY will be cleared. So it does work. Thanks.

Here is the updated patch.