Re: [Patch] video: remove pointless comments in drivers/video/console/vgacon.c

[Cong Wang]

ä 2011å01æ19æ 14:15, Paul Mundt åé:
> On Wed, Jan 19, 2011 at 02:08:22PM +0800, Cong Wang wrote:
> > ??? 2011???01???19??? 14:02, Paul Mundt ??????:
> > > On Wed, Jan 19, 2011 at 02:00:02PM +0800, Amerigo Wang wrote:
> > > > Now vgacon_scrollback_startup() uses slab, not bootmem,
> > > > so that comment is obsolete, the rest are useless.
> > > >
> > > > Signed-off-by: WANG Cong<amwang@xxxxxxxxxx>
> > > If you're going to do this then at least follow through and do the rest
> > > of it. The comment is no longer applicable, but then neither is the
> > > __init_refok annotation. Killing off the comment explaining why something
> > > is (or was there) without killing off the thing that is referenced by the
> > > comment is not terribly productive.
> >
> > Isn't __init_refok already a clear sign of "silence modpost"?
> > Why need to comment it again?
>
> __init_refok was to silence what was presumably an alloc_bootmem()
> reference at the time that the slab allocations were not early enough to
> satisfy the allocation, necessitating the use of bootmem. Since kmalloc
> and friends became usable early enough and the bootmem allocation has
> subsequently been dropped, there's no longer any need for the annotation.
>
> ie, alloc_bootmem() itself is __init while vgacon_scrollback_startup() is
> not, hence the modpost complaint.

Ah, I see, will remove '__init_refok' as well.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/