Re: [RFC 0/2] remove BT references from TI_ST

[Pavan Savoy]

Gustavo,

On Tue, Jan 4, 2011 at 4:29 PM,  <pavan_savoy@xxxxxx> wrote:
> From: Pavan Savoy <pavan_savoy@xxxxxx>
>
> Gustavo,
>
> Based on your comments, that the underlying shared transport driver
> for btwilink driver made use of the BT references to peek into the packets
> I have modified the TI_ST.

Since there lacks a generic way to parse the packets coming in from the
UART into BT, FM or GPS, we have to look into the data to fragment assembled
data or assemble fragmented data.

Please have a look, Please suggest whether something like this is required,
If not, please also suggest, if including BT headers is a problem ?

Because I just include the BT headers and don't have a build
dependency as such on
BT/HCI and don't use any functions from hci_core in my shared transport driver.

> For this reason, Now the above lying protocol drivers like BT, FM and GPS
> would send details about their packet types and header information which
> would assist shared transport driver to parse the data.
>
> Gustavo, please also notice the change in btwilink driver in and around,
> st_register and suggest if something like this is OK.
> btwilink can also be modified to send in all the packet specific data
> in one shot, if that is preferred.
>
> Please review and provide comments..
>
> Note:
> If this is alright, I will send out a modified patch with updated
> subject to lkml/Greg for linux-next.
>
> Thanks & Regards,
> Pavan Savoy.
>
> Pavan Savoy (2):
> Âdrivers:misc:ti-st: change protocol parse logic
> ÂBluetooth: btwilink driver
>
> Âdrivers/bluetooth/Kconfig  Â|  10 +
> Âdrivers/bluetooth/Makefile  |  Â1 +
> Âdrivers/bluetooth/btwilink.c | Â397 ++++++++++++++++++++++++++++++++++++++++++
> Âdrivers/misc/ti-st/st_core.c | Â355 ++++++++++++--------------------------
> Âdrivers/misc/ti-st/st_kim.c Â| Â 56 +++---
> Âinclude/linux/ti_wilink_st.h | Â 40 +++--
> Â6 files changed, 575 insertions(+), 284 deletions(-)
> Âcreate mode 100644 drivers/bluetooth/btwilink.c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/