Re: [PATCH] fsnotify: Do not always merge overflow events

From: Eric Paris
Date: Wed Jan 19 2011 - 15:37:17 EST


On Fri, 2010-11-26 at 12:39 +0100, Lino Sanfilippo wrote:

> With this patch we only merge an overflow event if the last event in the
> queue is also an overflow event.

I liked the idea, but not the patch. It left some dead return_event
code, but more importantly I'd rather keep the generic code generic if
we could. I merged this patch instead which pushes the handling out to
fanotify_merge, so if some listener wants other complex behavior they
can handle it.

What do you think?