Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271
From: Pierre Tardy
Date: Thu Jan 20 2011 - 02:17:57 EST
>
> This adds a defined-but-not-used warning. The MMC tree doesn't
> currently generate any warnings, so it would be good to avoid adding new
> ones, though I understand why it might make sense in this case.
Yes, this is supposed to be used by future user patches.
Do you suggest to add __attribute__ ((unused)), or we just completly
remove those and will add them whenever we have user?
>> static const struct mmc_fixup mmc_fixup_methods[] = {
>> { SDIO_ANY_ID, SDIO_ANY_ID,
>> add_quirk_for_sdio_devices, MMC_QUIRK_BROKEN_CLK_GATING }
>> + { SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271,
>> + remove_quirk_hook, MMC_QUIRK_BROKEN_CLK_GATING },
>> { 0 }
>> };
>>
>
> This doesn't compile, missing a comma. Was it tested?
Hum, I must have screwed up with patch version.
I'm using this every day,,,
Regards,
Pierre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/