Re: [REGRESSION] S3 resume on SandyBridge doesn't work with NXprotection (5bd5a45)

From: Matthias Hopf
Date: Thu Jan 20 2011 - 10:59:17 EST


On Jan 20, 11 16:05:54 +0100, castet.matthieu@xxxxxxx wrote:
> > > > Git commit 5bd5a45 in Linus' tree "x86: Add NX protection for kernel
> > > > data" apparently breaks resume on SandyBridge machines. This is
> > > > supposed to be fixed with commit 691513f "x86: Resume trampoline must
> > > > be executable", but even git master (v2.6.38-rc1) shows the same
> > > > symptoms.
> > > Is it a 32bit or 64 bit kernel ?
> >
> > Sorry, forgot that. It's a 32bit kernel.
> Ok that explain why 691513f doesn't work
> >
> Does this sequence make the machine reboot ?
>
> # echo 0 > /sys/devices/system/cpu/cpu1/online
> # echo 1 > /sys/devices/system/cpu/cpu1/online

Nope, it doesn't.

dmesg output:

[ 8172.670422] Unmapping cpu 1 from all nodes
[ 8172.671802] CPU 1 is now offline
[ 8176.572869] Booting Node 0 Processor 1 APIC 0x1
[ 8176.583474] Initializing CPU#1
[ 8176.583803] Mapping cpu 1 to node 0

Looks good to me.
I also tried disabling all but one CPUs (this is a quad core machine),
works as well.


Matthias

--
Matthias Hopf <mhopf@xxxxxxx> __ __ __
Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@xxxxxxxxx
Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/