Re: [PATCH 4/4] memcg: fix rmdir, force_empty with THP

[nishimura]

>> > @@ -2278,17 +2287,23 @@ static int mem_cgroup_move_parent(struct
>> >  		goto out;
>> >  	if (isolate_lru_page(page))
>> >  		goto put;
>> > +	/* The page is isolated from LRU and we have no race with splitting */
>> > +	charge = PAGE_SIZE << compound_order(page);
>> 
>> Why is LRU isolation preventing the splitting?
>> 
Oops! It seems that this comment made me confuse 'split' and 'collapse'.
Yes, it's 'collapse', not 'split', that is prevented by isolation.

> I use compound_lock now. I'll post clean up.
> 
I'll wait for your patch.

Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/