Re: [PATCH] adfs: add hexadecimal filetype suffix option

[Stuart Swales]

On Wed, 19 Jan 2011, Andrew Morton wrote:

> On Wed, 12 Jan 2011 18:07:23 +0000
> Stuart Swales <stuart.swales.croftnuisk@xxxxxxxxx> wrote:
>
> > From: Stuart Swales<stuart.swales.croftnuisk@xxxxxxxxx>
> >
> > ADFS (FileCore) storage complies with the RISC OS filetype specification
> > (12 bits of file type information is stored in the file load address, rather
> > than using a file extension).  The existing driver largely ignores this
> > information and does not present it to the end user.
> >
> > It is desirable that stored filetypes be made visible to the end user to
> > facilitate a precise copy of data and metadata from a hard disc (or image
> > thereof) into a RISC OS emulator (such as RPCEmu) or to a network share which
> > can be accessed by real Acorn systems.
> >
> > This patch implements a per-mount filetype suffix option (use -o ftsuffix=1)
> > to present any filetype as a ,xyz hexadecimal suffix on each file.  This type
> > suffix is compatible with that used by RISC OS systems that access network
> > servers using NFS client software and by RPCemu's host filing system.
> >
>
> I don't really understand this.  Are you saying that if a file on an
> adfs partition has name "foo", and one does a `mount -o ftsuffix=1'
> then an `ls' would show "foo,ABC"?
>
> If so, that sounds strange but I assume you know what you're doing.

Yes, indeed it would!  This is needed so we can store RISC OS file type
info on non-native systems.  This has been useful in the past to
share files over NFS and will be useful in future when migrating RISC
OS apps and data over onto virtualized systems such as the RISC OS
emulator RPCemu.


> Was `mount -o remount,ftsuffix=1' implemented and tested?

I didn't specifically check it out with remount.  Is that likely to be a
problem?

> Am I correct in assuming that "mount -o remount,ftsuffix=0" turns this
> off again?
>
> I wonder what are the implications of changing filenames on the fly
> with a remount.


> We have a Documentation/filesystems/adfs.txt.  Please update it.

Done.  Thanks for the pointer.


> Again, the patch was mangled by your email client in some fashion and
> generates 100% rejects.
>
> Please pass the diff through scripts/checkpatch.pl and address and
> warnings which you do not disagree with.


I blame icedove again!

Cheers,

Stuart Swales
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/