Re: [PATCH V9 08/13] posix clocks: cleanup the CLOCK_DISPTACHmacro

[Thomas Gleixner]

On Sat, 22 Jan 2011, Richard Cochran wrote:

> On Thu, Jan 13, 2011 at 06:03:24PM +0100, Thomas Gleixner wrote:
> > On Thu, 13 Jan 2011, Richard Cochran wrote:
> > >  int posix_cpu_clock_getres(const clockid_t which_clock, struct timespec *ts);
> > >  int posix_cpu_clock_get(const clockid_t which_clock, struct timespec *ts);
> > > -int posix_cpu_clock_set(const clockid_t which_clock, const struct timespec *ts);
> > > +int posix_cpu_clock_set(const clockid_t which_clock, struct timespec *ts);
> > 
> > Shouldn't we change the clock_set function to have *ts const in all places ?
> 
> The common_clock_set function calls:
> 
>     do_sys_settimeofday
>         security_settime
>             cap_settime
>     do_settimeofday
> 
> so all their signatures must also change.
> 
> Should I add that into my patch set?

Yes please as a separate patch.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/