Re: [PATCH v2 13/28] ARM: tegra: Add suspend and hotplug support
From: Russell King - ARM Linux
Date: Mon Jan 24 2011 - 05:15:39 EST
On Mon, Jan 24, 2011 at 01:26:39AM -0800, Colin Cross wrote:
> Despite what the patch description says, this version of the patch
> does not save VFP state any more. I will update the description.
I was going by the definitions of the context save area.
> It looks like if CONFIG_SMP=y, the VFP code saves the VFP context on
> every task switch, so nothing is needed during cpu idle. However, if
> CONFIG_SMP=n, I think some way to save the VFP context is needed.
I think we need proper idle PM support as I think this will become
> This version of the patch does not save breakpoint/watchdogs, but
> something will need to save them during idle when the cpu is powered
> > Lastly, L2 cache controller should have suspend/resume support added.
> Patch 4 in this series improves the L2 controller's PM support, and
> this patch uses l2x0_disable, l2x0_enable, and l2x0_init.
I was going by the definitions of the context save state - maybe the
ones which aren't used anymore should be removed?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/