Re: [PATCH 08/12] perf: Carve out mmap helpers for general use

From: Arnaldo Carvalho de Melo
Date: Mon Jan 24 2011 - 07:39:55 EST


Em Mon, Jan 24, 2011 at 10:04:10AM +0100, Borislav Petkov escreveu:
> Ok, I see at least one problem with my patch - you've reworked the
> mmaping functionality in evlist.c/evsel.c and I should use it too, I
> guess. For that, I think you'd want me to apply my stuff ontop of your
> perf/core branch, right?

Right, I hope to have that branch merged by Ingo soon.

> Am I missing something else?

Nope, you're not. Doing that we erode your patchset a bit, reducing its
size.

One related experience I'm doing now is to have a perf.so python
binding, the setup.py file for it with the list of files needed for this
specific binding is at:

http://userweb.kernel.org/~acme/setup.py

A simple tool using the resulting binding is a thread
fork/comm/exit/sample watcher, available at:

http://userweb.kernel.org/~acme/twatch

In this process I'm moving functions around so as to reduce the number
of tools/perf/util.c files to link into this perf.so python binding,
untangling things as much as possible.

The binding proper is:

http://userweb.kernel.org/~acme/python.c

I'm digressing, but twatch is an example of a simple "daemon" consuming
perf events where performance is not much of a problem.

And provides a prototyping ground when starting to design perf events
consuming daemons :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/