Re: [PATCH v2 20/28] ARM: tegra: cpufreq: Disable cpufreq duringsuspend
From: Mark Brown
Date: Mon Jan 24 2011 - 09:41:51 EST
On Sun, Jan 23, 2011 at 06:01:25PM -0800, Colin Cross wrote:
> Adds a SUSPEND_PREPARE notification hook to drop the frequency to
> the lowest possible during suspend. This prevents the cpufreq driver
> from attempting regulator calls after suspend has started - the
> regulator api can call into drivers that have already been suspended.
Hrm, what's the situation where that happens and why does it cause
problems? The regulator API doesn't care if suspend is going on, and
nor do any of the current drivers for regulators. There is an issue
with keeping things like I2C alive until the bitter end of suspend so
you've got a control bus to the regulators but that's a generic issue
which crops up with other subsystems too so a regulator-specific
workaround seems dodgy.
The patch itself seems fine, it's just that it feels like there's
something else going on.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/