Re: [PATCH] a patch to fix the cpu-offline-online problem causedby pm_idle
From: Peter Zijlstra
Date: Tue Jan 25 2011 - 04:11:33 EST
On Mon, 2011-01-24 at 20:59 -0500, Luming Yu wrote:
> > Ow god this is ugly.. pm_idle should die asap, not find it way into generic code, so NAK!
> Without the ugly fix, we seem not able to fix the problem in short time.
> Or , Are you suggesting to wrap pm_idle or similar in some generic
> code that would not disappear in foreseeable future ,
There are patches out there removing pm_idle from x86 (at least).
pm_idle is a horribly broken interface that really should die.
> Or Are you just
> suggesting me don't do the stuff in kerne/cpu.c, and do it in Arch
Well, as it stand only about half the architectures out there even have
a pm_idle pointer, so your patch would break the other half.
If you really need to do this, do it in arch code, but really, why is
this needed at all? The changelog failed to explain wth happens and why
this solves it.
> But..I bet It's not that wise to let CPU hot-plug code to interact
> with PM code for all Arch, so I proposed the ugly patch in generic
Which as I mentioned breaks about half the architectures we have.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/