Re: [PATCH v2 01/11] msm: Add CPU queries

From: David Brown
Date: Tue Jan 25 2011 - 14:45:33 EST


On Tue, Jan 25 2011, Daniel Walker wrote:

> On Tue, 2011-01-25 at 11:17 -0800, David Brown wrote:

> I suggesting we do it across the board because consistency is a good
> thing .. It also allows us to use 8x60 when 8660 and 8960 are actually
> similar .. You can't deny that 8960 is similar to 8660 because your
> patches show some duplication due to it.

You're completely missing the point of these tests. If _anything_ is
different, the macros need to be different. I don't care if they're
similar, I need to know when they are different. That is the point of
the macros.

David

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/