Re: [PATCH] firmware_classs: change val uevent's type to bool
From: Greg KH
Date: Wed Jan 26 2011 - 05:56:54 EST
On Wed, Jan 26, 2011 at 06:03:32PM +0800, Bob Liu wrote:
> On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@xxxxxxxxx> wrote:
> > @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
> > f_dev->parent = device;
> > f_dev->class = &firmware_class;
> > - dev_set_uevent_suppress(f_dev, true);
> > + if (uevent)
> > + dev_set_uevent_suppress(f_dev, true);
> > Everything but this is a no-op basically, but you didn't even describe this change?
> Hmm.. Sorry for that, but I mentioned that by "fix a place missing
> uevent check".
> I added this check because I think it should be paired with following
> dev_set_uevent_suppress(f_dev, false).
That's fine, but please, split that out into a separate patch.
Remember, a patch should only do one thing.
Please resend this as two patches and I will be glad to queue it up.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/