Re: [PATCH 4/5] staging: ft1000: Fix coding style inwrite_blk_fifo() function.

From: Dan Carpenter
Date: Wed Jan 26 2011 - 09:31:00 EST


Also when it does:
memcpy(ft1000dev->tx_buf, *pUcFile, byte_length);

That should probably be:
memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4);

Otherwise we're probably copying garbage from beyond the end of *pUcFile
to the ->tx_buf. ft1000dev->tx_buf is hopefully initialized to zero at
this point?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/