Re: [PATCH v4] smc91x: add devicetree support

From: Grant Likely
Date: Wed Jan 26 2011 - 10:33:20 EST

On Wed, Jan 26, 2011 at 8:17 AM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
> On Wed, 26 Jan 2011, Thomas Chou wrote:
>> Signed-off-by: Thomas Chou <thomas@xxxxxxxxxxxxx>
>> ---
>> v2 specify part numbers in compat as Grant suggested.
>> v3 more specific part name.
>> v4 include match table only for OF as David suggested.
> The smc91x driver relies on many parameters which are platform specific,
> such as the bus width capabilities, register spacing due to special bus
> wiring, interrupt signal level, LED configuration, whether or not to
> configure the chip with a wait state, etc.  Will the device tree support
> take care of those things?

Short answer, yes

In general bindings are written and documented as they are needed. In
this specific case,yes the device configuration should be encoded into
the device tree node. It is okay for now to not wire up any of that
configuration if the defaults work for Thomas' platform, but to be
useful in the long run they do need to be added.

Typically a block or function call is added to the drivers .probe hook
to decode device tree data if the of_node pointer is set.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at