RE: [PATCH 0/8] Basic ARM device tree support

From: John Linn
Date: Wed Jan 26 2011 - 15:06:18 EST

> -----Original Message-----
> From: Grant Likely [mailto:glikely@xxxxxxxxxxxx] On Behalf Of Grant Likely
> Sent: Tuesday, January 18, 2011 1:29 PM
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: Nicolas Pitre; Russell King; Catalin Marinas; devicetree-discuss@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Olof Johansson; Jeremy Kerr; John Linn; Lennert Buijtenhek
> Subject: [PATCH 0/8] Basic ARM device tree support
> It's been a while since these patches have been circulated for review.
> Much has changed since the last posting and there are no longer any
> ugly hacks or workarounds to it working. From my viewpoint, these
> patches are complete and ready to be used.
> This patch series allows CONFIG_OF to be enabled on ARM and allows the
> kernel to accept a dtb pointer from boot firmware instead of atags.
> If a dtb is passed, then the kernel will use the root 'compatible'
> property to find a matching machine_desc, and it will use it to obtain
> the memory layout, initrd location and kernel parameters string.
> Only limited device tree support is enabled here. It does not perform
> any kind of device registration from device tree data. That support
> will be enabled in a later patch set. Right now those patches depend
> on the common struct clk patches that Jeremy is working on, so I'm not
> going to post them yet. Rather, this series is a stable base that
> other engineers can use to start working on device tree support for
> their platforms.
> Tested on Versatile (qemu) and nVidia Tegra Harmony. Kernel compiles
> an boot with CONFIG_OF both on and off, both with and without passing
> a device tree blob.

Tested on Xilinx platform. Did see an issue with loading the device
tree blob into higher memory. At address 0 there was no issue.

> I've published this series to a new branch on my git server:
> git:// devicetree/arm
> The way I've managed the devicetree/test branch in the past has made
> it hard for other engineers to work with the device tree support, so
> I'm changing the way I'm handling it. I will *not* rebase this new
> branch. My intention is to keep it in essentially 'merge-ready' state
> at all times. ie. I'm only going to put patches into this branch that
> I consider complete and are required to enable arm device tree
> support. ie. core dt infrastructure and dt board support. Device
> drivers should be submitted directly to their respective
> lists/maintainers. I'll also be soliciting acks from platform
> maintainers before I pick up board support patches into this branch.
> Russell: I'm not expecting you to merge these now, nor am I asking
> you to. I won't do so until I've got a full implementation using the
> device tree to register devices on the machine and supporting multiple
> machines. However, would you mind taking a look at these patches and
> commenting on the approach? Particularly the early boot code.
> Thanks.
> Cheers,
> g.

Thanks for this patch set. Device tree on ARM will be a great help to Xilinx.

Tested-by: John Linn <john.linn@xxxxxxxxxx>

> ---
> The following changes since commit
> a25cecce88194b2edf38b8c3b1665e9318eb2d22:
> Merge branch 'next' of git:// (2011-01-18 08:06:22 -0800)
> are available in the git repository at:
> git:// devicetree/arm
> Grant Likely (7):
> arm/dt: Make __vet_atags also accept a dtb image
> arm/dt: allow bootmem reservation for device tree blob and initrd
> arm/dt: consolidate atags setup into setup_machine_atags
> arm/dt: probe for platforms via the device tree
> arm/dt: Basic versatile devicetree support
> arm/tegra: Fix tegra irq_data conversion
> arm/dt: Basic tegra devicetree support
> Jeremy Kerr (1):
> arm/dt: Allow CONFIG_OF on ARM
> arch/arm/Kconfig | 7 ++
> arch/arm/include/asm/mach/arch.h | 2 +
> arch/arm/include/asm/prom.h | 34 ++++++++++
> arch/arm/include/asm/setup.h | 4 +
> arch/arm/kernel/Makefile | 1
> arch/arm/kernel/devtree.c | 107 ++++++++++++++++++++++++++++++++
> arch/arm/kernel/head-common.S | 19 ++++--
> arch/arm/kernel/head.S | 8 +-
> arch/arm/kernel/setup.c | 78 +++++++++++++----------
> arch/arm/mach-tegra/board-harmony.c | 6 ++
> arch/arm/mach-tegra/gpio.c | 4 +
> arch/arm/mach-versatile/versatile_ab.c | 6 ++
> arch/arm/mach-versatile/versatile_pb.c | 6 ++
> arch/arm/mm/init.c | 23 +++++++
> 14 files changed, 258 insertions(+), 47 deletions(-)
> create mode 100644 arch/arm/include/asm/prom.h
> create mode 100644 arch/arm/kernel/devtree.c
> --
> Signature

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_