Re: [PATCH 2/4] ptrace: remove the extra wake_up_process() fromptrace_detach()
From: Tejun Heo
Date: Thu Jan 27 2011 - 08:34:24 EST
On Mon, Jan 17, 2011 at 02:13:40PM -0800, Roland McGrath wrote:
> Of course I agree that the current code is wrong here. But I'm still not
> at all clear on what practical compatibility problems it introduces. This
> change is OK if and only if we are really making the only area clean and
> well-defined in the same release cycle.
I don't follow what you meant by the above sentence. Can you please
clarify a bit?
> It doesn't really matter that the old behavior was ill-defined and
> unreliable in absolute terms, because the practical userland
> experience of it in real-world cases is what userland has grown to
> expect. We can't break any such expectations until we have a clear
> answer about how to solve the problems correctly.
It's slightly more serious than that. Calling wake_up_process()
unconditionally can cause a quite serious failure. It wakes up a
process in any state and there are code paths which aren't prepared to
be woken up unless certain conditions are met. A safer choice can be
changing it to wake up only tasks in interruptible sleep.
I have very difficult time imagining what real user visible
implication it would have in negative and noticeable manner, so while
I do agree that we should proceed carefully, I think it would be
better to take the chance and remove the erratic behavior. We have
release cycles and testing at multiple layers after all. If we find
out that it breaks something in serious manner, we can always revert.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/