Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/
From: Amit Shah
Date: Thu Jan 27 2011 - 13:30:02 EST
On (Thu) Jan 20 2011 [10:03:43], Greg Kroah-Hartman wrote:
> As requested by Arnd Bergmann, the hvc drivers are now
> moved to the drivers/tty/hvc/ directory. The virtio_console.c driver
> was also moved, as it required the hvc_console.h file to be able to be
> built, and it really is a hvc driver.
I just saw this now as a result of this patch entering mainline. I
would have liked to be CC'ed to the patches. Also, I don't like the
move of the virtio_console.c file to drivers/tty/hvc. virtio_console.c
is not only an hvc driver; one of its functions is to hook some ports to
hvc, but it's mostly a generic driver these days.
(I also note the MAINTAINERS entry was ignored and not updated in the
3rd patch of this series.)
Can you please move it back?
I could perhaps think of a way of splitting the file so the hvc bits can
be moved to drivers/tty/hvc/ and having the core stay in drivers/char/,
but that'll have to wait for the next cycle.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/