Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/
From: Amit Shah
Date: Thu Jan 27 2011 - 21:57:45 EST
On (Thu) Jan 27 2011 [22:53:29], Arnd Bergmann wrote:
> On Thursday 27 January 2011 19:29:44 Amit Shah wrote:
> > On (Thu) Jan 20 2011 [10:03:43], Greg Kroah-Hartman wrote:
> > > As requested by Arnd Bergmann, the hvc drivers are now
> > > moved to the drivers/tty/hvc/ directory. The virtio_console.c driver
> > > was also moved, as it required the hvc_console.h file to be able to be
> > > built, and it really is a hvc driver.
> > I just saw this now as a result of this patch entering mainline. I
> > would have liked to be CC'ed to the patches. Also, I don't like the
> > move of the virtio_console.c file to drivers/tty/hvc. virtio_console.c
> > is not only an hvc driver; one of its functions is to hook some ports to
> > hvc, but it's mostly a generic driver these days.
> Sorry about this, the idea to move this file was mine and my original
> patch did this as well. I remembered the code from when it was a simple
> console driver based on hvc and never noticed that it had evolved into
> a generic host/guest communication stack.
> > Can you please move it back?
> No objection from me here in general, though as Greg writes above, it's
> a bit ugly when hvc_console.h is in a different directory.
Greg, can you do this please? (A way to do it with preservig git
history of the file would be great as well, but I think only a revert
will do that?)
> > I could perhaps think of a way of splitting the file so the hvc bits can
> > be moved to drivers/tty/hvc/ and having the core stay in drivers/char/,
> > but that'll have to wait for the next cycle.
> I think that's a really good idea. The main reason for moving the tty
> drivers from drivers/char to drivers/tty was to separate the everything
> related to tty from everything else. The common part should IMHO then not
> be named "console", "tty" os similar but indicate that it's more generic
> than that. Maybe virtio-pipe?
Rusty has suggested virtio-ports in the past.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/