Re: [PATCH V10 01/15] time: Introduce timekeeping_inject_offset

From: Richard Cochran
Date: Fri Jan 28 2011 - 02:08:15 EST

On Thu, Jan 27, 2011 at 10:48:19AM -0800, John Stultz wrote:
> While I appreciate you preserving the path author, and the signoffs are
> right, you really should send the email under your own name.

Guess I've been reading too much spam. It wore off on me.

> The proper style is to keep the mail-header From: the same (ie: Richard
> Cochran <richardcochran@xxxxxxxxx>), but as the first line of the mail
> body put:
> From: Author Name <author@xxxxxxxxxx>

Sorry about this. Arnd already explained this to me, and I did catch
it with V9. This time I forgot.

I would like to get to the bottom of this. Here is what I did:

1. Saved your patch to disk in mbox format using Mutt.
2. git am
3. ... rebase, rebase, rebase, ...
4. git format-patch [options] 1234..abcd
5. Edit cover letter
6. for x in 00*; do mutt -H $x; done

Git format-patch places the "From: John Stultz <john.stultz@xxxxxxxxxx>"
line with the other mail headers, and so I guess mutt just faithfully
preserves this.

I don't like having to remember to fix this manually. There must be a
better way...


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at