Re: [RFC] merge 32/64 bits realmode wakeup code

From: matthieu castet
Date: Sat Jan 29 2011 - 15:44:00 EST

Rafael J. Wysocki a écrit :
On Thursday, January 27, 2011, matthieu castet wrote:

this patch merge 32 and 64 realmode wakeup code :
- this mean less ifdef in code
- we could remove now unused field in wakeup_header (pmode_*)
- this allow to set the first 1 MB NX.

Do you think it is safe on all X86 32 bit machine ?


Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>

It _looks_ sane, but it will require some serious testing. I'm not sure,
though, if we can get enough testing coverage without actually committing
that change.

How much testing has it received so far?

Not too much only qemu with 1 and 2 core and a laptop with 1 cpu.

Please note that with this patch we can also remove the gdt, idt, ldt stuff from arch/x86/kernel/acpi/wakeup_32.S

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at