Re: [PATCH RFC] serial-core: reset the console speed on resume

From: Stanislav Brabec
Date: Sat Jan 29 2011 - 19:21:12 EST


Yin Kangkai wrote on Tue 25 Jan 2011 at 18:43 +0800:

> On some platforms, we need to restore the console speed on resume even
> it was not suspended (no_console_suspend), and on others we don't have
> to do that.
>
> So don't care about the "console_suspend_enabled" and unconditionally
> reset the console speed if it is a console.

Well, there is currently another breakage on Zaurus. But it improves the
situation.
(Note: Your patch has bad file path. I'll agree with such change after
this fix.)

Test report on Zaurus
(serial hardware itself is in undefined state after resume):

before after
login: OK OK
console: broken broken
console + login: OK OK
console + no_console_suspend: broken broken
login + no_console_suspend: OK OK
console + login + no_console_suspend: broken OK

--
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@xxxxxxx
Lihovarská 1060/12 tel: +49 911 7405384547
190 00 Praha 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/