Re: [PATCH] langwell_gpio: Fix deprecated refs to irq_desc->chipand chip->eoi

From: David Miller
Date: Sun Jan 30 2011 - 01:05:32 EST

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Tue, 25 Jan 2011 22:50:34 -0800 (PST)

> From: "Du, Alek" <alek.du@xxxxxxxxx>
> Date: Wed, 26 Jan 2011 14:48:02 +0800
>> Another patch from Feng Tang already covers this and picked up by Andrew Morton.
>> [patch 04/23] langwell_gpio: modify EOI handling following change of kernel irq subsystem
> Ok, thanks.

It doesn't cover "this". Somthing like my patch is still necessary to
get this driver to build:

drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler':
drivers/gpio/langwell_gpio.c:210:10: error: 'struct irq_desc' has no member named 'chip'
drivers/gpio/langwell_gpio.c:211:7: error: 'struct irq_desc' has no member named 'chip'

Subject: [PATCH] langwell_gpio: Fix deprecated refs to irq_desc->chip
From: David Miller <davem@xxxxxxxxxxxxx>

Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
index 54d70a4..fb3e439 100644
--- a/drivers/gpio/langwell_gpio.c
+++ b/drivers/gpio/langwell_gpio.c
@@ -207,8 +207,8 @@ static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
writel(gedr_v, gedr);

- if (desc->chip->irq_eoi)
- desc->chip->irq_eoi(irq_get_irq_data(irq));
+ if (desc->irq_data.chip->irq_eoi)
+ desc->irq_data.chip->irq_eoi(irq_get_irq_data(irq));
dev_warn(lnw->, "missing EOI handler for irq %d\n", irq);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at