Re: [PATCH 1/4] kmap_atomic: remove the second parameter

From: Peter Zijlstra
Date: Mon Jan 31 2011 - 04:55:25 EST

On Sun, 2011-01-30 at 17:46 +0800, Amerigo Wang wrote:
> Now the second parameter of kmap_atomic() are totally unused,
> this patch removes it from all callers.
> Most of this patch is generated by the following commands:
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkmap_atomic(\(.*\),.*)#kmap_atomic(\1)#' '{}' \;
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkunmap_atomic(\(.*\),.*)#kunmap_atomic(\1)#' '{}' \;
> However, there are some exceptions:
> 1) When the second parameter of kmap_atomic() is a variable
> 2) When the second parameter of kmap_atomic() is not in the same line
> For 1), they are mostly in btrfs and crypto code, have to fix
> one by one;
> For 2), I fixed them by hands too.
> This patch passes 'make allyesconfig' test on both i386 and x86_64.

Right, I had a mostly scripted patch like this as well, IIRC akpm didn't
particularly like the huge patch (in part because it was a flag day

Maybe cut the patch into slightly smaller bits, like arch/asm,
drivers/gpu, fs/btrfs etc..
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at