Re: [PATCH 3/6] PM: use appropriate printk priority level

From: Rafael J. Wysocki
Date: Mon Jan 31 2011 - 05:12:46 EST


On Thursday, January 27, 2011, Mandeep Singh Baines wrote:
> printk()s without a priority level default to KERN_WARNING. To reduce
> noise at KERN_WARNING, this patch set the priority level appriopriately
> for unleveled printks()s. This should be useful to folks that look at
> dmesg warnings closely.
>
> Changed these messages to pr_info. But might be more appropriate as
> pr_debug.
>
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> ---
> drivers/base/power/trace.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
> index 9f4258d..c80e138 100644
> --- a/drivers/base/power/trace.c
> +++ b/drivers/base/power/trace.c
> @@ -112,7 +112,7 @@ static unsigned int read_magic_time(void)
> unsigned int val;
>
> get_rtc_time(&time);
> - printk("Time: %2d:%02d:%02d Date: %02d/%02d/%02d\n",
> + pr_info("Time: %2d:%02d:%02d Date: %02d/%02d/%02d\n",
> time.tm_hour, time.tm_min, time.tm_sec,
> time.tm_mon + 1, time.tm_mday, time.tm_year % 100);
> val = time.tm_year; /* 100 years */
> @@ -179,7 +179,7 @@ static int show_file_hash(unsigned int value)
> unsigned int hash = hash_string(lineno, file, FILEHASH);
> if (hash != value)
> continue;
> - printk(" hash matches %s:%u\n", file, lineno);
> + pr_info(" hash matches %s:%u\n", file, lineno);
> match++;
> }
> return match;
> @@ -255,7 +255,7 @@ static int late_resume_init(void)
> val = val / FILEHASH;
> dev = val /* % DEVHASH */;
>
> - printk(" Magic number: %d:%d:%d\n", user, file, dev);
> + pr_info(" Magic number: %d:%d:%d\n", user, file, dev);
> show_file_hash(file);
> show_dev_hash(dev);
> return 0;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/