Re: [RFC -v7 PATCH 5/7] export pid symbols needed for kvm_vcpu_on_spin

From: Avi Kivity
Date: Mon Jan 31 2011 - 08:45:52 EST

On 01/31/2011 03:43 PM, Peter Zijlstra wrote:
On Mon, 2011-01-31 at 15:26 +0200, Avi Kivity wrote:
> On 01/31/2011 01:51 PM, Peter Zijlstra wrote:
> > On Wed, 2011-01-26 at 17:23 -0500, Rik van Riel wrote:
> > > Export the symbols required for a race-free kvm_vcpu_on_spin.
> >
> > Avi, you asked for an example of why I hated KVM as a module :-)
> Why do you dislike exports so much?

Because I hate modules [*],

Well, you could have just said you hate KVM as a module because it is a module, and saved one indirection.

since we sadly cannot undo those, limiting
the module interface is all we've got, and KVM is one that pushes the
module interface further and further.

Many people see an EXPORT as a acknowledgement that its OK to use the
interface, even when its not.

[*] they enable the binary junk thing.

Then we need to stop binary modules, not castrate modules as a whole.

error compiling committee.c: too many arguments to function

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at