[PATCH v2] oprofile: add SMP barriers for hrtimer hotplug code

From: Will Deacon
Date: Mon Jan 31 2011 - 12:53:24 EST

OProfile uses a CPU notifier to start and stop any hrtimers when CPUs change
between ONLINE and DEAD. A static int ctr_running is used to keep track of
the counter state.

This can lead to problems where writes to the state variable are re-ordered
with repect to reads of the variable occurring on other CPUs, meaning that
__oprofile_hrtimer_start may read ctr_running as 0 and not initialise the
hrtimer. Potential deadlock can occur in __oprofile_hrtimer_stop because
lock_hrtimer_base will poll until timer->base != NULL, which will never

This patch adds an smp_mb() before initialising the hrtimers to ensure that
ctr_running mirrors the correct counter state.

Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
Cc: Robert Richter <robert.richter@xxxxxxx>
Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Changes since v1: Removed redundant barrier from stop() code.

drivers/oprofile/timer_int.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/oprofile/timer_int.c b/drivers/oprofile/timer_int.c
index 0107251..a3a94ea 100644
--- a/drivers/oprofile/timer_int.c
+++ b/drivers/oprofile/timer_int.c
@@ -48,6 +48,7 @@ static int oprofile_hrtimer_start(void)
ctr_running = 1;
+ smp_mb();
on_each_cpu(__oprofile_hrtimer_start, NULL, 1);
return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/